Skip to content

[poc] Feature gates#907

Closed
deads2k wants to merge 5 commits intoopenshift:masterfrom
deads2k:feature-gates
Closed

[poc] Feature gates#907
deads2k wants to merge 5 commits intoopenshift:masterfrom
deads2k:feature-gates

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 10, 2023

Like #906 but with the new featuregate reading API. This works using the old openshift/api, but uses the new golang API to make updates easy.

/hold just a POC

jstuever added 3 commits April 5, 2023 14:55
@jstuever
Bump azidentity to v1.3.0 which includes support for WorkloadIdentity…
7385baf 
…Credential.
@jstuever
Enable Azure Workload Identity authentication.
0c93083 
Authenticate with an Azure Workload Identity (AZWI) serviceaccount token
when client secret is absent from auth config.
@jstuever
Add AzureWorkloadIdentity featureGate
230278d
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2023
@openshift-ci openshift-ci bot requested review from knobunc and rfredette April 10, 2023 22:37
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign miciah for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented Apr 11, 2023

image 500

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2023

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn a5e3106 link false /test e2e-azure-ovn
ci/prow/verify a5e3106 link true /test verify
ci/prow/e2e-aws-ovn a5e3106 link true /test e2e-aws-ovn
ci/prow/images a5e3106 link true /test images
ci/prow/e2e-gcp-operator a5e3106 link true /test e2e-gcp-operator
ci/prow/e2e-aws-ovn-upgrade a5e3106 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-gcp-ovn a5e3106 link false /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-serial a5e3106 link true /test e2e-aws-ovn-serial
ci/prow/e2e-azure-operator a5e3106 link true /test e2e-azure-operator
ci/prow/e2e-aws-ovn-single-node a5e3106 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-operator a5e3106 link true /test e2e-aws-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k closed this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knobunc knobunc Awaiting requested review from knobunc

@rfredette rfredette Awaiting requested review from rfredette

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deads2k @jstuever